LibProtocol: Ensure download is finished before invoking on_finished

alimpfard · awesomekling · commit a6b04cf8ef8d · 2020-12-31T16:57:09.000+01:00
diff --git a/Libraries/LibProtocol/Download.cpp b/Libraries/LibProtocol/Download.cpp
@@ -66,7 +66,7 @@ void Download::stream_into(OutputStream& stream)
             TODO();
         }
 
-        if (m_internal_stream_data->read_stream.eof() || (m_internal_stream_data->download_done && !m_internal_stream_data->success)) {
+        if (m_internal_stream_data->read_stream.eof() && m_internal_stream_data->download_done) {
             m_internal_stream_data->read_notifier->close();
             user_on_finish(m_internal_stream_data->success, m_internal_stream_data->total_size);
         } else {

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ void Download::stream_into(OutputStream& stream)`
`66`	`66`	`TODO();`
`67`	`67`	`}`
`68`	`68`
`69`		`- if (m_internal_stream_data->read_stream.eof() \|\| (m_internal_stream_data->download_done && !m_internal_stream_data->success)) {`
	`69`	`+ if (m_internal_stream_data->read_stream.eof() && m_internal_stream_data->download_done) {`
`70`	`70`	`m_internal_stream_data->read_notifier->close();`
`71`	`71`	`user_on_finish(m_internal_stream_data->success, m_internal_stream_data->total_size);`
`72`	`72`	`} else {`