Skip to content

Commit a99cd09

Browse files
BenWiederhaketrflynn89
authored andcommitted
Libraries: Add missing includes, add namespace qualifiers
This remained undetected for a long time as HeaderCheck is disabled by default. This commit makes the following file compile again: // file: compile_me.cpp #include <LibDNS/Question.h> // That's it, this was enough to cause a compilation error. Likewise for most other files touched by this commit.
1 parent 48d8aff commit a99cd09

File tree

10 files changed

+15
-4
lines changed

10 files changed

+15
-4
lines changed

Userland/Libraries/LibCodeComprehension/Shell/ConnectionFromClient.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class ConnectionFromClient final : public LanguageServers::ConnectionFromClient
1919
ConnectionFromClient(NonnullOwnPtr<Core::Stream::LocalSocket> socket)
2020
: LanguageServers::ConnectionFromClient(move(socket))
2121
{
22-
m_autocomplete_engine = make<ShellComprehensionEngine>(m_filedb);
22+
m_autocomplete_engine = make<CodeComprehension::Shell::ShellComprehensionEngine>(m_filedb);
2323
m_autocomplete_engine->set_declarations_of_document_callback = [this](String const& filename, Vector<CodeComprehension::Declaration>&& declarations) {
2424
async_declarations_in_document(filename, move(declarations));
2525
};

Userland/Libraries/LibDNS/Question.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
#pragma once
88

9+
#include "Answer.h"
910
#include "Name.h"
1011
#include <AK/Types.h>
1112

Userland/Libraries/LibGPU/StencilConfiguration.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
#pragma once
88

9+
#include <LibGPU/Config.h>
910
#include <LibGPU/Enums.h>
1011

1112
namespace GPU {

Userland/Libraries/LibGfx/Font/VectorFont.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
#include <AK/Noncopyable.h>
1010
#include <AK/RefCounted.h>
11+
#include <LibGfx/Forward.h>
1112

1213
namespace Gfx {
1314

Userland/Libraries/LibGfx/PNGShared.h

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66

77
#pragma once
88

9+
#include <AK/Array.h>
10+
#include <AK/SIMD.h>
11+
912
namespace Gfx::PNG {
1013

1114
// https://www.w3.org/TR/PNG/#5PNG-file-signature
@@ -33,9 +36,9 @@ enum class FilterType : u8 {
3336
ALWAYS_INLINE u8 paeth_predictor(u8 a, u8 b, u8 c)
3437
{
3538
int p = a + b - c;
36-
int pa = abs(p - a);
37-
int pb = abs(p - b);
38-
int pc = abs(p - c);
39+
int pa = AK::abs(p - a);
40+
int pb = AK::abs(p - b);
41+
int pc = AK::abs(p - c);
3942
if (pa <= pb && pa <= pc)
4043
return a;
4144
if (pb <= pc)

Userland/Libraries/LibIPC/Encoder.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
#pragma once
88

99
#include <AK/Concepts.h>
10+
#include <AK/HashMap.h>
1011
#include <AK/StdLibExtras.h>
1112
#include <LibCore/SharedCircularQueue.h>
1213
#include <LibIPC/Forward.h>

Userland/Libraries/LibLine/Style.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
#include <AK/String.h>
1010
#include <AK/Types.h>
11+
#include <AK/Utf8View.h>
1112
#include <AK/Vector.h>
1213
#include <stdlib.h>
1314

Userland/Libraries/LibPDF/XRefTable.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#include <AK/RefCounted.h>
1111
#include <AK/String.h>
1212
#include <AK/Vector.h>
13+
#include <LibPDF/Error.h>
1314

1415
namespace PDF {
1516

Userland/Libraries/LibSoftGPU/SIMD.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
#pragma once
88

99
#include <AK/SIMDExtras.h>
10+
#include <AK/SIMDMath.h>
1011
#include <LibGfx/Vector2.h>
1112
#include <LibGfx/Vector3.h>
1213
#include <LibGfx/Vector4.h>

Userland/Libraries/LibXML/DOM/Node.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
#pragma once
88

9+
#include <AK/HashMap.h>
910
#include <AK/NonnullOwnPtrVector.h>
1011
#include <AK/String.h>
1112
#include <AK/Variant.h>

0 commit comments

Comments
 (0)