Skip to content

Commit ab49fcf

Browse files
kleinesfilmroellchenlinusg
authored andcommitted
LibAudio+Userland: Remove Audio::LegacyBuffer
The file is now renamed to Queue.h, and the Resampler APIs with LegacyBuffer are also removed. These changes look large because nobody actually needs Buffer.h (or Queue.h). It was mostly transitive dependencies on the massive list of includes in that header, which are now almost all gone. Instead, we include common things like Sample.h directly, which should give faster compile times as very few files actually need Queue.h.
1 parent f14a71e commit ab49fcf

27 files changed

+39
-297
lines changed

β€ŽUserland/Applications/Piano/AudioPlayerLoop.hβ€Ž

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,9 @@
88
#pragma once
99

1010
#include "Music.h"
11-
#include <LibAudio/Buffer.h>
1211
#include <LibAudio/ConnectionFromClient.h>
12+
#include <LibAudio/Resampler.h>
13+
#include <LibAudio/Sample.h>
1314
#include <LibAudio/WavWriter.h>
1415
#include <LibCore/Event.h>
1516
#include <LibCore/Object.h>

β€ŽUserland/Applications/Piano/Track.hβ€Ž

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
#include <AK/Noncopyable.h>
1414
#include <AK/NonnullRefPtr.h>
1515
#include <AK/SinglyLinkedList.h>
16-
#include <LibAudio/Buffer.h>
1716
#include <LibDSP/Effects.h>
1817
#include <LibDSP/Music.h>
1918
#include <LibDSP/Synthesizers.h>

β€ŽUserland/Applications/Piano/main.cppβ€Ž

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
#include "MainWidget.h"
1212
#include "TrackManager.h"
1313
#include <AK/Queue.h>
14-
#include <LibAudio/Buffer.h>
1514
#include <LibAudio/ConnectionFromClient.h>
1615
#include <LibAudio/WavWriter.h>
1716
#include <LibCore/EventLoop.h>

β€ŽUserland/Applications/SoundPlayer/AlbumCoverVisualizationWidget.hβ€Ž

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
#pragma once
99

1010
#include "VisualizationWidget.h"
11-
#include <LibAudio/Buffer.h>
1211
#include <LibGUI/Frame.h>
1312

1413
class AlbumCoverVisualizationWidget final : public VisualizationWidget {

β€ŽUserland/Applications/SoundPlayer/BarsVisualizationWidget.hβ€Ž

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
#include <AK/Array.h>
1212
#include <AK/Complex.h>
1313
#include <AK/FixedArray.h>
14-
#include <LibAudio/Buffer.h>
1514
#include <LibGUI/Frame.h>
1615

1716
class BarsVisualizationWidget final : public VisualizationWidget {

β€ŽUserland/Applications/SoundPlayer/PlaybackManager.hβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010
#include <AK/FixedArray.h>
1111
#include <AK/Queue.h>
1212
#include <AK/Vector.h>
13-
#include <LibAudio/Buffer.h>
1413
#include <LibAudio/ConnectionFromClient.h>
1514
#include <LibAudio/Loader.h>
15+
#include <LibAudio/Resampler.h>
1616
#include <LibAudio/Sample.h>
1717
#include <LibCore/Timer.h>
1818

β€ŽUserland/Applications/SoundPlayer/SampleWidget.cppβ€Ž

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
#include "SampleWidget.h"
99
#include <AK/Math.h>
10-
#include <LibAudio/Buffer.h>
1110
#include <LibGUI/Painter.h>
1211

1312
SampleWidget::SampleWidget()

β€ŽUserland/Applications/SoundPlayer/VisualizationWidget.hβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
#include <AK/FixedArray.h>
1010
#include <AK/Forward.h>
1111
#include <AK/TypedTransfer.h>
12-
#include <LibAudio/Buffer.h>
12+
#include <LibAudio/Sample.h>
1313
#include <LibGUI/Frame.h>
1414
#include <LibGUI/Painter.h>
1515

β€ŽUserland/Libraries/LibAudio/Buffer.cppβ€Ž

Lines changed: 0 additions & 139 deletions
This file was deleted.

β€ŽUserland/Libraries/LibAudio/Buffer.hβ€Ž

Lines changed: 0 additions & 104 deletions
This file was deleted.

0 commit comments

Comments
Β (0)