Skip to content

Commit b6435ca

Browse files
committed
LibJS: Unify bytecode instruction names with their helper names
1 parent 272be6b commit b6435ca

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

Userland/Libraries/LibJS/Bytecode/Interpreter.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -515,22 +515,22 @@ ThrowCompletionOr<void> Store::execute_impl(Bytecode::Interpreter&) const
515515
__builtin_unreachable();
516516
}
517517

518-
static ThrowCompletionOr<Value> abstract_inequals(VM& vm, Value src1, Value src2)
518+
static ThrowCompletionOr<Value> loosely_inequals(VM& vm, Value src1, Value src2)
519519
{
520520
return Value(!TRY(is_loosely_equal(vm, src1, src2)));
521521
}
522522

523-
static ThrowCompletionOr<Value> abstract_equals(VM& vm, Value src1, Value src2)
523+
static ThrowCompletionOr<Value> loosely_equals(VM& vm, Value src1, Value src2)
524524
{
525525
return Value(TRY(is_loosely_equal(vm, src1, src2)));
526526
}
527527

528-
static ThrowCompletionOr<Value> typed_inequals(VM&, Value src1, Value src2)
528+
static ThrowCompletionOr<Value> strict_inequals(VM&, Value src1, Value src2)
529529
{
530530
return Value(!is_strictly_equal(src1, src2));
531531
}
532532

533-
static ThrowCompletionOr<Value> typed_equals(VM&, Value src1, Value src2)
533+
static ThrowCompletionOr<Value> strict_equals(VM&, Value src1, Value src2)
534534
{
535535
return Value(is_strictly_equal(src1, src2));
536536
}

Userland/Libraries/LibJS/Bytecode/Op.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,10 @@ class Store final : public Instruction {
9292
O(GreaterThanEquals, greater_than_equals) \
9393
O(LessThan, less_than) \
9494
O(LessThanEquals, less_than_equals) \
95-
O(LooselyInequals, abstract_inequals) \
96-
O(LooselyEquals, abstract_equals) \
97-
O(StrictlyInequals, typed_inequals) \
98-
O(StrictlyEquals, typed_equals) \
95+
O(LooselyInequals, loosely_inequals) \
96+
O(LooselyEquals, loosely_equals) \
97+
O(StrictlyInequals, strict_inequals) \
98+
O(StrictlyEquals, strict_equals) \
9999
O(BitwiseAnd, bitwise_and) \
100100
O(BitwiseOr, bitwise_or) \
101101
O(BitwiseXor, bitwise_xor) \

Userland/Libraries/LibJS/JIT/Compiler.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -577,22 +577,22 @@ void Compiler::compile_throw(Bytecode::Op::Throw const&)
577577
check_exception();
578578
}
579579

580-
static ThrowCompletionOr<Value> abstract_inequals(VM& vm, Value src1, Value src2)
580+
static ThrowCompletionOr<Value> loosely_inequals(VM& vm, Value src1, Value src2)
581581
{
582582
return Value(!TRY(is_loosely_equal(vm, src1, src2)));
583583
}
584584

585-
static ThrowCompletionOr<Value> abstract_equals(VM& vm, Value src1, Value src2)
585+
static ThrowCompletionOr<Value> loosely_equals(VM& vm, Value src1, Value src2)
586586
{
587587
return Value(TRY(is_loosely_equal(vm, src1, src2)));
588588
}
589589

590-
static ThrowCompletionOr<Value> typed_inequals(VM&, Value src1, Value src2)
590+
static ThrowCompletionOr<Value> strict_inequals(VM&, Value src1, Value src2)
591591
{
592592
return Value(!is_strictly_equal(src1, src2));
593593
}
594594

595-
static ThrowCompletionOr<Value> typed_equals(VM&, Value src1, Value src2)
595+
static ThrowCompletionOr<Value> strict_equals(VM&, Value src1, Value src2)
596596
{
597597
return Value(is_strictly_equal(src1, src2));
598598
}

Userland/Libraries/LibJS/JIT/Compiler.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,10 @@ class Compiler {
5050
O(Mod, mod) \
5151
O(In, in) \
5252
O(InstanceOf, instance_of) \
53-
O(LooselyInequals, abstract_inequals) \
54-
O(LooselyEquals, abstract_equals) \
55-
O(StrictlyInequals, typed_inequals) \
56-
O(StrictlyEquals, typed_equals)
53+
O(LooselyInequals, loosely_inequals) \
54+
O(LooselyEquals, loosely_equals) \
55+
O(StrictlyInequals, strict_inequals) \
56+
O(StrictlyEquals, strict_equals)
5757

5858
# define JS_ENUMERATE_COMPARISON_OPS(O) \
5959
O(LessThan, less_than, SignedLessThan) \

0 commit comments

Comments
 (0)