Skip to content

Commit d4734e9

Browse files
committed
Meta: Define HAVE_QT when building WebContent for Qt in the GN build
For some reason, WebContent fails to load simple sites like xkcd.com without the Qt event loop, even when using RequestServer instead of the Qt networking stack. The CMake build on Linux has the same issue if we skip installing the Qt event loop. It's not clear why this is - whether something depends on the Qt event loop, or if there's a bug in the Unix event loop implementation. This is, however, also needed to use the --enable-qt-networking feature.
1 parent 951aa44 commit d4734e9

File tree

1 file changed

+2
-0
lines changed
  • Meta/gn/secondary/Ladybird/WebContent

1 file changed

+2
-0
lines changed

Meta/gn/secondary/Ladybird/WebContent/BUILD.gn

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ executable("WebContent") {
7272
]
7373

7474
if (enable_qt) {
75+
defines = [ "HAVE_QT" ]
7576
configs += [ ":WebContent_qt" ]
7677
sources += [
7778
"//Ladybird/Qt/EventLoopImplementationQt.cpp",
@@ -83,6 +84,7 @@ executable("WebContent") {
8384
]
8485

8586
if (enable_qt_multimedia) {
87+
defines += [ "HAVE_QT_MULTIMEDIA" ]
8688
sources += [
8789
"//Ladybird/Qt/AudioCodecPluginQt.cpp",
8890
"//Ladybird/Qt/AudioThread.cpp",

0 commit comments

Comments
 (0)