LibJS: Use a forwarding reference in ThrowCompletion constructor

mattco98 · linusg · commit d4b08b719652 · 2023-03-06T13:05:43.000Z
This avoids compiler complaints when trying to use const types
diff --git a/Userland/Libraries/LibJS/Runtime/Completion.h b/Userland/Libraries/LibJS/Runtime/Completion.h
@@ -307,7 +307,7 @@ class [[nodiscard]] ThrowCompletionOr {
     // Most commonly: Value from Object* or similar, so we can omit the curly braces from "return { TRY(...) };".
     // Disabled for POD types to avoid weird conversion shenanigans.
     template<typename WrappedValueType>
-    ThrowCompletionOr(WrappedValueType const& value)
+    ThrowCompletionOr(WrappedValueType&& value)
     requires(!IsPOD<ValueType>)
         : m_value_or_throw_completion(ValueType { value })
     {

Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,7 @@ class [[nodiscard]] ThrowCompletionOr {`
`307`	`307`	`// Most commonly: Value from Object* or similar, so we can omit the curly braces from "return { TRY(...) };".`
`308`	`308`	`// Disabled for POD types to avoid weird conversion shenanigans.`
`309`	`309`	`template<typename WrappedValueType>`
`310`		`- ThrowCompletionOr(WrappedValueType const& value)`
	`310`	`+ ThrowCompletionOr(WrappedValueType&& value)`
`311`	`311`	`requires(!IsPOD<ValueType>)`
`312`	`312`	`: m_value_or_throw_completion(ValueType { value })`
`313`	`313`	`{`