Skip to content

Commit dccfff8

Browse files
committed
ProfileViewer: Don't crash when we can't disassemble something
1 parent 8daddcf commit dccfff8

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

DevTools/ProfileViewer/DisassemblyModel.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,15 @@ DisassemblyModel::DisassemblyModel(Profile& profile, ProfileNode& node)
5555
, m_node(node)
5656
{
5757
m_file = make<MappedFile>(profile.executable_path());
58+
59+
if (!m_file->is_valid())
60+
return;
61+
5862
auto elf_loader = make<ELF::Loader>((const u8*)m_file->data(), m_file->size());
5963

6064
auto symbol = elf_loader->find_symbol(node.address());
65+
if (!symbol.has_value())
66+
return;
6167
ASSERT(symbol.has_value());
6268

6369
auto view = symbol.value().raw_data();

0 commit comments

Comments
 (0)