Kernel: Fail gracefully due to OOM on HashTable set in sys$setgroups

IdanHo · IdanHo · commit e23d320bb964 · 2022-01-26T02:37:03.000+02:00
diff --git a/Kernel/Syscalls/setuid.cpp b/Kernel/Syscalls/setuid.cpp
@@ -187,7 +187,7 @@ ErrorOr<FlatPtr> Process::sys$setgroups(size_t count, Userspace<const gid_t*> us
     HashTable<gid_t> unique_extra_gids;
     for (auto& extra_gid : new_extra_gids) {
         if (extra_gid != gid())
-            unique_extra_gids.set(extra_gid);
+            TRY(unique_extra_gids.try_set(extra_gid));
     }
 
     ProtectedDataMutationScope scope { *this };

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ ErrorOr<FlatPtr> Process::sys$setgroups(size_t count, Userspace<const gid_t*> us`
`187`	`187`	`HashTable<gid_t> unique_extra_gids;`
`188`	`188`	`for (auto& extra_gid : new_extra_gids) {`
`189`	`189`	`if (extra_gid != gid())`
`190`		`- unique_extra_gids.set(extra_gid);`
	`190`	`+ TRY(unique_extra_gids.try_set(extra_gid));`
`191`	`191`	`}`
`192`	`192`
`193`	`193`	`ProtectedDataMutationScope scope { *this };`