LibJS: Avoid an unnecessary Vector copy in IndexedProperties::indices()

awesomekling · awesomekling · commit ea81a4a529b5 · 2021-02-17T15:23:32.000+01:00
diff --git a/Userland/Libraries/LibJS/Runtime/IndexedProperties.cpp b/Userland/Libraries/LibJS/Runtime/IndexedProperties.cpp
@@ -374,7 +374,7 @@ Vector<u32> IndexedProperties::indices() const
         }
     } else {
         const auto& storage = static_cast<const GenericIndexedPropertyStorage&>(*m_storage);
-        const auto packed_elements = storage.packed_elements();
+        const auto& packed_elements = storage.packed_elements();
         indices.ensure_capacity(storage.array_like_size());
         for (size_t i = 0; i < packed_elements.size(); ++i) {
             if (!packed_elements.at(i).value.is_empty())

Original file line number	Diff line number	Diff line change
`@@ -374,7 +374,7 @@ Vector<u32> IndexedProperties::indices() const`
`374`	`374`	`}`
`375`	`375`	`} else {`
`376`	`376`	`const auto& storage = static_cast<const GenericIndexedPropertyStorage&>(*m_storage);`
`377`		`- const auto packed_elements = storage.packed_elements();`
	`377`	`+ const auto& packed_elements = storage.packed_elements();`
`378`	`378`	`indices.ensure_capacity(storage.array_like_size());`
`379`	`379`	`for (size_t i = 0; i < packed_elements.size(); ++i) {`
`380`	`380`	`if (!packed_elements.at(i).value.is_empty())`