Skip to content

Commit eb83d26

Browse files
AtkinsSJawesomekling
authored andcommitted
LibWeb: Use a CSSRuleList inside CSSStyleSheet
This better matches the spec. :^)
1 parent 97a78cd commit eb83d26

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

Userland/Libraries/LibWeb/CSS/CSSStyleSheet.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#include <AK/TypeCasts.h>
1111
#include <LibWeb/CSS/CSSImportRule.h>
1212
#include <LibWeb/CSS/CSSRule.h>
13+
#include <LibWeb/CSS/CSSRuleList.h>
1314
#include <LibWeb/CSS/StyleSheet.h>
1415
#include <LibWeb/Loader/Resource.h>
1516

@@ -28,8 +29,8 @@ class CSSStyleSheet final : public StyleSheet {
2829

2930
virtual String type() const override { return "text/css"; }
3031

31-
const NonnullRefPtrVector<CSSRule>& rules() const { return m_rules; }
32-
NonnullRefPtrVector<CSSRule>& rules() { return m_rules; }
32+
CSSRuleList const& rules() const { return m_rules; }
33+
CSSRuleList& rules() { return m_rules; }
3334

3435
template<typename Callback>
3536
void for_each_effective_style_rule(Callback callback) const
@@ -66,7 +67,7 @@ class CSSStyleSheet final : public StyleSheet {
6667
private:
6768
explicit CSSStyleSheet(NonnullRefPtrVector<CSSRule>);
6869

69-
NonnullRefPtrVector<CSSRule> m_rules;
70+
CSSRuleList m_rules;
7071
};
7172

7273
}

Userland/Libraries/LibWeb/Dump.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ void dump_sheet(StringBuilder& builder, CSS::StyleSheet const& sheet)
523523
{
524524
auto& css_stylesheet = verify_cast<CSS::CSSStyleSheet>(sheet);
525525

526-
builder.appendff("CSSStyleSheet{{{}}}: {} rule(s)\n", &sheet, css_stylesheet.rules().size());
526+
builder.appendff("CSSStyleSheet{{{}}}: {} rule(s)\n", &sheet, css_stylesheet.rules().length());
527527

528528
for (auto& rule : css_stylesheet.rules()) {
529529
dump_rule(builder, rule);

0 commit comments

Comments
 (0)