FileSystem: fix errno on lseek() beyond the bounds of a file

These are all EINVAL. Also remove bogus assert on metadata.size.
SerenityOS · May 16, 2019 · f1f3cd5 · f1f3cd5
1 parent abb7455
commit f1f3cd5
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/Kernel/FileSystem/FileDescriptor.cpp b/Kernel/FileSystem/FileDescriptor.cpp
@@ -142,17 +142,17 @@ off_t FileDescriptor::seek(off_t offset, int whence)
         break;
     case SEEK_CUR:
         newOffset = m_current_offset + offset;
-        if (newOffset < 0)
-            return -EINVAL;
         break;
     case SEEK_END:
-        ASSERT(metadata.size); // FIXME: What do I do?
         newOffset = metadata.size;
         break;
     default:
         return -EINVAL;
     }
 
+    if (newOffset < 0 || newOffset > metadata.size)
+        return -EINVAL;
+
     m_current_offset = newOffset;
     return m_current_offset;
 }