Skip to content

Commit f533030

Browse files
tomutaawesomekling
authored andcommitted
Kernel: Stop back trace on a null base pointer
This silences some warnings trying to copy from null when capturing a stack trace.
1 parent ad7030c commit f533030

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Kernel/Thread.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -868,7 +868,7 @@ String Thread::backtrace_impl()
868868
FlatPtr stack_ptr, eip;
869869
if (Processor::get_context_frame_ptr(*this, stack_ptr, eip)) {
870870
recognized_symbols.append({ eip, symbolicate_kernel_address(eip) });
871-
for (;;) {
871+
while (stack_ptr) {
872872
FlatPtr retaddr;
873873

874874
if (is_user_range(VirtualAddress(stack_ptr), sizeof(FlatPtr) * 2)) {
@@ -906,7 +906,7 @@ Vector<FlatPtr> Thread::raw_backtrace(FlatPtr ebp, FlatPtr eip) const
906906
backtrace.append(eip);
907907
FlatPtr stack_ptr_copy;
908908
FlatPtr stack_ptr = (FlatPtr)ebp;
909-
for (;;) {
909+
while (stack_ptr) {
910910
void* fault_at;
911911
if (!safe_memcpy(&stack_ptr_copy, (void*)stack_ptr, sizeof(FlatPtr), fault_at))
912912
break;

0 commit comments

Comments
 (0)