Skip to content

Commit fdfffe2

Browse files
peterbbAtkinsSJ
authored andcommitted
LibWeb: Use IPv6Address::loopback() instead of parsing "::1"
When comparing an ipv6 address against '::1', then compare against the value object from `IPv6Address::loopback()`, instead of parsing the string "::1" to an IPv6Address.
1 parent 10aed80 commit fdfffe2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Userland/Libraries/LibWeb/SecureContexts/AbstractOperations.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Trustworthiness is_origin_potentially_trustworthy(HTML::Origin const& origin)
3030
// 4. If origin’s host matches one of the CIDR notations 127.0.0.0/8 or ::1/128 [RFC4632], return "Potentially Trustworthy".
3131
if (auto ipv4_address = IPv4Address::from_string(origin.host()); ipv4_address.has_value() && (ipv4_address->to_u32() & 0xff000000) != 0)
3232
return Trustworthiness::PotentiallyTrustworthy;
33-
if (auto ipv6_address = IPv6Address::from_string(origin.host()); ipv6_address.has_value() && ipv6_address->to_deprecated_string() == "::1")
33+
if (auto ipv6_address = IPv6Address::from_string(origin.host()); ipv6_address.has_value() && ipv6_address == IPv6Address::loopback())
3434
return Trustworthiness::PotentiallyTrustworthy;
3535

3636
// 5. If the user agent conforms to the name resolution rules in [let-localhost-be-localhost] and one of the following is true:

0 commit comments

Comments
 (0)