Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Support interpolation of mixed percentage dimension units #24444

Merged

Conversation

mattco98
Copy link
Collaborator

This is much simpler than the previous solution I came up with for this, which was to introduce a new StyleValue type that then somehow had to propagate through all of the CalculatedOr/PercentageOr stuff.

Fixes #23543

@mattco98 mattco98 requested a review from AtkinsSJ as a code owner May 25, 2024 20:34
@github-actions github-actions bot added 👀 pr-needs-review PR needs review from a maintainer or community member labels May 25, 2024
@mattco98 mattco98 force-pushed the animate-with-mixed-percentages branch 3 times, most recently from 7f845e8 to 3631d00 Compare May 25, 2024 20:55
Copy link
Member

@AtkinsSJ AtkinsSJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very elegant solution! I only have nit-picks.

Userland/Libraries/LibWeb/CSS/StyleComputer.cpp Outdated Show resolved Hide resolved
Userland/Libraries/LibWeb/CSS/StyleComputer.cpp Outdated Show resolved Hide resolved
@mattco98 mattco98 force-pushed the animate-with-mixed-percentages branch from 3631d00 to 4d72245 Compare May 26, 2024 14:31
@mattco98 mattco98 force-pushed the animate-with-mixed-percentages branch from 4d72245 to 5a119b3 Compare May 26, 2024 14:35
@awesomekling awesomekling merged commit e2cb25e into SerenityOS:master Jun 2, 2024
12 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Jun 2, 2024
@mattco98 mattco98 deleted the animate-with-mixed-percentages branch June 2, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LibWeb: CSS animation of transform property does not work correctly
3 participants