-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Everywhere: Gently remove the ladybird android port #24555
Conversation
With Ladybird now being its own repository, there's little reason to keep the Ladybird Android port in the SerenityOS repository. (The Qt port is useful to be able to test changes to LibWeb in lagom so it'll stay around. Similar for the AppKit port, since getting Qt on macOS is a bit annoying. But if the AppKit port is too much pain to keep working, we should toss that too. Eventually, the lagom browser ports should move out from Ladybird/ to Meta/Lagom/Contrib, but for now it might make sense to leave them where they are to keep cherry-picks from ladybird easier.)
Didn't catch it in my scroll through but there's a nightly android GitHub actions job that should be removed if you missed it |
Also, is removing all android support from the core libraries the right call? I've seen people run the Shell and |
I think it's fine to put that back if people actually run lagom binaries on Android, but I figured it's better to err on removing too much than too little. |
Do I just delete that file? I added a commit for that, thanks. Could you take a look if it looks right? |
yes, just deleting the file is the way. for Azure DevOps there was a 'main' file that triggered the jobs, but for github just having the workflow file in the right place is the thing to do. looks good to me |
With Ladybird now being its own repository, there's little reason to keep the Ladybird Android port in the SerenityOS repository.
(The Qt port is useful to be able to test changes to LibWeb in lagom so it'll stay around. Similar for the AppKit port, since getting Qt on macOS is a bit annoying. But if the AppKit port is too much pain to keep working, we should toss that too.
Eventually, the lagom browser ports should move out from Ladybird/ to Meta/Lagom/Contrib, but for now it might make sense to leave them where they are to keep cherry-picks from ladybird easier.)