Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support training set only #361

Merged
merged 17 commits into from
Jan 13, 2023
Merged

Support training set only #361

merged 17 commits into from
Jan 13, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Jan 5, 2023

Resolve #362

Description:

  • Support only a training set (no eval) for further flexibility. Look at the commits for the details of what was done.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma force-pushed the ggm/support-training-set-only branch from 0c5150a to b37cb01 Compare January 6, 2023 17:57
@JosephMarinier JosephMarinier mentioned this pull request Jan 7, 2023
4 tasks
@gabegma gabegma marked this pull request as ready for review January 9, 2023 21:50
Copy link
Collaborator

@christyler3030 christyler3030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend stuff looks fine.

JosephMarinier and others added 3 commits January 10, 2023 17:00
* Better manage loading `datasetInfo` to remove the need for countless `?`s.
* Select available dataset by default for behavioral testing preview
* Select available dataset by default for exploration space
* Add dataset split in URL for smart tag analysis page
* Add dataset split in URL for pipeline performance page
* Polish error messages
* Add dataset split in URL for class overlap page to be consistent with the back end and the other pages.
gabegma and others added 2 commits January 12, 2023 18:15
Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's gooo! 💪

@gabegma gabegma merged commit fceeee6 into main Jan 13, 2023
@gabegma gabegma deleted the ggm/support-training-set-only branch January 13, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Azimuth work on just a training set
3 participants