Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config scope for MetricsPerFilterModule #399

Merged
merged 3 commits into from
Jan 27, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Jan 27, 2023

Description:

  • When dataset warnings thresholds will be modified, this will no longer affect MetricsPerFilter.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma requested review from lindsaydbrin and JosephMarinier and removed request for lindsaydbrin January 27, 2023 16:04
@gabegma gabegma self-assigned this Jan 27, 2023
azimuth/config.py Outdated Show resolved Hide resolved
Copy link
Contributor

@lindsaydbrin lindsaydbrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactoring thought! Thanks!

Just a question and suggestion about naming.

@gabegma gabegma enabled auto-merge (squash) January 27, 2023 19:58
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@gabegma gabegma merged commit 80bd5ab into main Jan 27, 2023
@gabegma gabegma deleted the ggm/metric-per-filter-scope branch January 27, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants