Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dataset manager #427

Merged
merged 4 commits into from
Feb 10, 2023
Merged

Refactor dataset manager #427

merged 4 commits into from
Feb 10, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Feb 8, 2023

Part of #297

Description:

  • Refactor get_tags so the output is the same as the input format for add_tags. It felt odd to me that they were slightly different (list vs dict). Let me know if you disagree, I can change it back to a list.
    • I removed the pandas conversion and the method is now faster.
    • I refactored the test which was messy and didn't test much the get_tags method.
  • Add a new method to convert persistent_id to row_idx. This will be useful for my next PR, where we modify the route to update the tags.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma force-pushed the ggm/refactor-dataset-manager branch from c470d63 to a3a8af9 Compare February 8, 2023 01:36
@gabegma gabegma marked this pull request as ready for review February 8, 2023 02:04
@gabegma gabegma self-assigned this Feb 8, 2023
@gabegma gabegma force-pushed the ggm/refactor-dataset-manager branch from a3a8af9 to 281511a Compare February 8, 2023 03:26
@gabegma gabegma mentioned this pull request Feb 9, 2023
5 tasks
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
@gabegma gabegma enabled auto-merge (squash) February 10, 2023 21:08
@gabegma gabegma merged commit 5b9f969 into main Feb 10, 2023
@gabegma gabegma deleted the ggm/refactor-dataset-manager branch February 10, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants