Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute syntax smart tags for utterances with multiple sentences. #435

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Feb 10, 2023

Resolve #434

Description:

  • This will make it easier for datasets with long utterances (with multiple sentences) to have meaningful syntax smart tags.
  • This will enable us to display the long/short utterances on the token count plot.
  • I took this opportunity to refactor the syntax tagging tests, so they test all results (they also weren't working because of using all instead of any.)

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma force-pushed the ggm/compute-long-short-utterances branch from 739d55b to 05c6da4 Compare February 10, 2023 19:19
@gabegma gabegma marked this pull request as ready for review February 10, 2023 19:21
@gabegma gabegma requested review from JosephMarinier and lindsaydbrin and removed request for JosephMarinier February 10, 2023 19:21
@gabegma gabegma self-assigned this Feb 10, 2023
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! And good catch! 👍 I just have small ideas to improve the tests.

@gabegma gabegma enabled auto-merge (squash) February 10, 2023 21:45
@gabegma gabegma merged commit e3a9026 into main Feb 10, 2023
@gabegma gabegma deleted the ggm/compute-long-short-utterances branch February 10, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert short_sentence and long_sentence to short_utterance and long_utterance.
2 participants