-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load config history #472
Load config history #472
Conversation
44ab1ca
to
859a96b
Compare
defaulting to loading config from env vars only
so I can make a dummy release and try the docker image.
859a96b
to
498870a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time to make a clear PR. I was hesitant, but I see it more clearly now. I like it. So the default is to ignore the history, right? So no confusion if someone does make CFG_PATH='bla.json' launch
; they will see 'bla' in Azimuth, no matter the config history.
docs/docs/development/launching.md
Outdated
@@ -65,6 +65,22 @@ From this point, the back end will launch and compute the start-up task. | |||
* You can consult the openapi documentation at `localhost:8091/docs`. From there, you can consult the API documentation and try out the different endpoints. This can be useful for debugging. | |||
* Note that the back end will not reload automatically based on code changes. | |||
|
|||
After a successful start, Azimuth saves the provided config in its `config_history.jsonl` artifact. If you use the API to edit the config, the edits are saved there. If you restart Azimuth (for example after shutting it down for the night), you can resume where you left off with `LOAD_CONFIG_HISTORY=1`. In order to find the right `config_history.jsonl`, Azimuth needs the same `ARTIFACT_PATH`, so to resume the above example, it needs to be specified: | |||
```shell | |||
make ARTIFACT_PATH=cache LOAD_CONFIG_HISTORY=1 launch.local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our Python code, we could consider making "cache"
the default artifact path, useful locally, rather than "/cache"
, useful in docker, and set it to "/cache"
in our Dockerfile
. Tha would simplify:
make ARTIFACT_PATH=cache LOAD_CONFIG_HISTORY=1 launch.local | |
make LOAD_CONFIG_HISTORY=1 launch.local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks like a good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in bf8861a
I like it. It also makes the documentation more straightforward; a simpler description of the "normal" use case with the default artifact_path
, and then a warning box about customizing artifact_path
.
relying on our (already existing) code to validate that the dataset is defined after loading the final config.
4431988
to
dd94ef2
Compare
I had used the syntax of `make` instead of `sh`. Documentation: https://www.gnu.org/software/bash/manual/bash.html#Shell-Parameter-Expansion:~:text=unset%20or%20null-,%24%7Bparameter%3A%2Bword%7D,-If%20parameter%20is
…oad-config-history * commit '674585e9bdfd543771ee74b407059b41fc979f24': Clean up docker image (#316) Validate config min/max values (#474) Bump werkzeug from 2.1.0 to 2.2.3 (#443) Bump dns-packet from 5.3.1 to 5.4.0 in /webapp (#473) Update tensorflow (#355) Bump json5 from 1.0.1 to 1.0.2 in /webapp (#359) Fix negative query params (#471)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Awesome new feature, great work!
This reverts commit 498870a.
since changing the default `artifact_path` to `"cache"` made that unnecessary.
Description:
artifact_path
default to"cache"
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-files
at the end.our users.
README
files and our wiki for any big design decisions, if relevant.