-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.1.0 #81
Merged
Release 2.1.0 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cleanup fixtures and tests * Change according to review and fix tests * Fix front-end * Adapt new test in merge * Fix front end test
* Remove unnecessary theme overwrite, as we were overwriting with the default value. This used to make sense as we were reusing the `DEFAULT_SPACING` constant elsewhere, but we no longer do. * Use typing to force parsing all query parameters
* enable postprocessing changes applied on the UI * renamed withoutPostprocessing alias * renamed types in withoutPostprocessing * added alias to without_postprocessing * added withoutprocessing to utterance page and sort features * added postprocessing param to filter change * added changelog * Add query parameter alias * Adapt utterances table without postprocessing * added review comment changes * renamed model to postprocessing * removed formgroup and let the default MUI property stay * set default MUI behaviour and name consistency on all files * removed switch component and added in control section * deleted switch component * Fix loosing `withoutPostprocessing` when switching pipeline * Fix loosing `withoutPostprocessing` when clicking top words Co-authored-by: joseph.marinier <joseph.marinier@servicenow.com>
* Polish top words links (#60) * Clean up using destructuring assignment to avoid repeating `wordCount` 5 times * Make clicking a top word a second time clear search * Double underline of selected top word * Document top words links * Update screenshot * Fix link styling in table rows * Add Git flow instruction to documentation (#63) * Add Git flow instruction to documentation * Update docs/docs/development/dev-practices.md * Add citation * Update CITATION.cff * Use label column name from config in outcome (#70) * Fixed typos in Special Thanks section (#71) Fixed typo "Sean Hugues" to "Sean Hughes" and added comma after "Sethu Meiyappan," Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com> Co-authored-by: gabrielle.gm <gabrielle.gm@servicenow.com> Co-authored-by: Sean Hughes <hughesthe1st@users.noreply.github.com>
* Fix filter family deactivated style * Rename `enable` to `checked` * Polish spacing * Change switch label from "Without PostProcessing" to "Exclude post-processing" * Add tooltip Co-authored-by: christyler3030 <46576263+christyler3030@users.noreply.github.com>
* Fix issue where we sent OutcomeCountPerThreshold filters * Update frontend types
Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
* Update release notes * Update version * Update screenshot
JosephMarinier
approved these changes
May 27, 2022
auto-merge was automatically disabled
May 27, 2022 18:58
Rebase failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.
ran
pre-commit run --all-files
at the end.Run
cd webapp && yarn types
while the back-end is running.our users.
README
files and our wiki for any big design decisions, if relevant.