Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.1.0 #81

Merged
merged 14 commits into from
May 27, 2022
Merged

Release 2.1.0 #81

merged 14 commits into from
May 27, 2022

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented May 27, 2022

Description:

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.

  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • FRONTEND TYPES. Regenerate the front-ent types if you played with types and routes.
    Run cd webapp && yarn types while the back-end is running.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

Dref360 and others added 14 commits May 5, 2022 11:45
* Cleanup fixtures and tests

* Change according to review and fix tests

* Fix front-end

* Adapt new test in merge

* Fix front end test
* Remove unnecessary theme overwrite, as we were overwriting with the default value. This used to make sense as we were reusing the `DEFAULT_SPACING` constant elsewhere, but we no longer do.

* Use typing to force parsing all query parameters
* enable postprocessing changes applied on the UI

* renamed withoutPostprocessing alias

* renamed types in withoutPostprocessing

* added alias to without_postprocessing

* added withoutprocessing to utterance page and sort features

* added postprocessing param to filter change

* added changelog

* Add query parameter alias

* Adapt utterances table without postprocessing

* added review comment changes

* renamed model to postprocessing

* removed formgroup and let the default MUI property stay

* set default MUI behaviour and name consistency on all files

* removed switch component and added in control section

* deleted switch component

* Fix loosing `withoutPostprocessing` when switching pipeline

* Fix loosing `withoutPostprocessing` when clicking top words

Co-authored-by: joseph.marinier <joseph.marinier@servicenow.com>
* Polish top words links (#60)

* Clean up using destructuring assignment to avoid repeating `wordCount` 5 times
* Make clicking a top word a second time clear search
* Double underline of selected top word
* Document top words links
* Update screenshot
* Fix link styling in table rows

* Add Git flow instruction to documentation (#63)

* Add Git flow instruction to documentation

* Update docs/docs/development/dev-practices.md

* Add citation

* Update CITATION.cff

* Use label column name from config in outcome (#70)

* Fixed typos in Special Thanks section (#71)

Fixed typo "Sean Hugues" to "Sean Hughes" and added comma after "Sethu Meiyappan,"

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
Co-authored-by: gabrielle.gm <gabrielle.gm@servicenow.com>
Co-authored-by: Sean Hughes <hughesthe1st@users.noreply.github.com>
* Fix filter family deactivated style
* Rename `enable` to `checked`
* Polish spacing
* Change switch label from "Without PostProcessing" to "Exclude post-processing"
* Add tooltip
Co-authored-by: christyler3030 <46576263+christyler3030@users.noreply.github.com>
* Fix issue where we sent OutcomeCountPerThreshold filters

* Update frontend types
Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
* Update release notes

* Update version

* Update screenshot
@gabegma gabegma enabled auto-merge (rebase) May 27, 2022 18:34
auto-merge was automatically disabled May 27, 2022 18:58

Rebase failed

@gabegma gabegma merged commit 0518769 into main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants