change state if RITM state changes #1399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create before insert/update business rule on sc_req_item table and give condition if state changes to 2 OR cat_item.sc.catalogs is "yourchoice"
readme file to provide details on business rule to change state.
msdfib
reviewed
Oct 20, 2024
| gr.orderBy('order'); | ||
| gr.setLimit(1); | ||
| gr.query(); | ||
| if (gr.next() && gr.getValue('state') == 1) { |
There was a problem hiding this comment.
If you added this condition to the query, you would not need to check the state for '1' (the magic number).
There was a problem hiding this comment.
removed "if" condition from the script, instead added inside the query.
msdfib
reviewed
Oct 20, 2024
| var gr = new GlideRecord("sc_task"); | ||
| gr.addQuery('request_item', current.sys_id); | ||
| gr.orderBy('order'); | ||
| gr.setLimit(1); |
There was a problem hiding this comment.
What if more than one sc_task is under RITM?
There was a problem hiding this comment.
removed setLimit(1) so that it will update all the sc_task related to RITM
msdfib
reviewed
Oct 20, 2024
|
|
||
| var gr = new GlideRecord("sc_task"); | ||
| gr.addQuery('request_item', current.sys_id); | ||
| gr.orderBy('order'); |
There was a problem hiding this comment.
You don't need to sort the results if you don't have a clear reason, in this case, you are sorting a list with one record.
There was a problem hiding this comment.
removed the orderBy query
Lacah
requested changes
Oct 20, 2024
updated the script : sc_task will change the state from open to work in progress when RITM state changes to work in progress (set this condition in filer condition).
Adil404
commented
Oct 21, 2024
Adil404
commented
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This business rule is to set state of sc_task table when sc_req_item state changes.
Create before insert/update business rule on sc_req_item table and give condition if state changes to 2 OR cat_item.sc.catalogs is "take your choice".