-
Notifications
You must be signed in to change notification settings - Fork 694
Get my reports dynamic filters - fixed! #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SapphicFire
merged 18 commits into
ServiceNowDevProgram:main
from
smartcarleen:getMyReportsDynamicFilters
Oct 14, 2023
Merged
Get my reports dynamic filters - fixed! #830
SapphicFire
merged 18 commits into
ServiceNowDevProgram:main
from
smartcarleen:getMyReportsDynamicFilters
Oct 14, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looping script traverses the User table from a certain point to get either one level of employees or all employees in the hierarchy underneath the logged-on user. There are two functions: 1. **getMyDirectReports**: gets only users directly reporting to the logged on user 1. **getMyReports**: gets all users reporting to the logged on user
…icFilters.xml Removed XML for BR. I recommend that users create this new in their instance based on the details from the readme.
Updated readme to account for the shift to code to a Client Callable script include.
added screenshots to illustrate
SapphicFire
approved these changes
Oct 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, appreciate the refactor too. Thanks for the contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow I borked the code when submitting my pull request the other day. Since I had to fix it anyway, I spent some time refactoring this into a Client Callable Script Include instead of a Global Business Rule (which is the better way to do it anyway).
I updated the readme accordingly and also included a few screenshots to help illustrate usage. Feedback welcome!