This repository was archived by the owner on Dec 24, 2022. It is now read-only.
Use SSCAN for DeleteAll by default to avoid pulling large sets into memory.
#257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling all keys into memory all at once. This will reduce memory, but make the command chatty for very large typed sets.
Add tests for deletes bigger than batch size. Change to use while loop rather than recursion.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a possible solution, ideally the client can control
pageSizesince it will impact how chatty the command is for perform the delete all, but currently this isn't a configurable option on the client that I can see.The other trade off will be compatibility as this would require Redis 2.8 at a minimum, where as SMEMBERS has been around since 1.0. Saying that Redis latest stable is 6.2 and only officially supports -2 from stable.