Skip to content
This repository was archived by the owner on Dec 24, 2022. It is now read-only.

Conversation

ddotlic
Copy link
Contributor

@ddotlic ddotlic commented Jun 17, 2013

Not superfluous, the previous version was broken. One user even reported it,
but we mistakenly did not test the released version but the (at the time)
current version of the source. For reference, the broken version - still on
NuGet - is 3.9.44; don't let this version fool you, SL5 build lag behind the
official build number so 3.9.49 includes SL5 binaries 3.9.44.
The crash happened in ServiceClientBase's constructor due to the misuse of
the CookieContainer.
Current code works fine, let's update SL5 build and update NuGet...

Not superfluous, the previous version was broken. One user even reported it,
but we mistakenly did not test the released version but the (at the time)
current version of the source. For reference, the broken version - still on
NuGet - is 3.9.44; don't let this version fool you, SL5 build lag behind the
official build number so 3.9.49 includes SL5 binaries 3.9.44.
The crash happened in ServiceClientBase's constructor due to the misuse of
the CookieContainer.
Current code works fine, let's update SL5 build and update NuGet...
mythz added a commit that referenced this pull request Jun 17, 2013
If possible, please push a new version to NuGet - see below, currently published version is broken (I am available for more info)
@mythz mythz merged commit b93ab47 into ServiceStack:master Jun 17, 2013
@mythz
Copy link
Member

mythz commented Jun 17, 2013

ok i'll look to push a new release out tonight, not: the next version will be v3.9.53 since I've had to push a few versions of ServiceStack.Redis out:
https://nuget.org/packages/ServiceStack.Redis/

@mythz
Copy link
Member

mythz commented Jun 17, 2013

FYI I just increased the version numbers of SS and SS.Text to v3.9.53. I'll be looking at publishing a new release to NuGet tonight.

@ddotlic
Copy link
Contributor Author

ddotlic commented Jun 17, 2013

Does this mean that published version will be *.53?

@mythz
Copy link
Member

mythz commented Jun 17, 2013

Yep.

*.53 is the next version after the max version already published which was SS.Redis at *.52.

@ddotlic
Copy link
Contributor Author

ddotlic commented Jun 17, 2013

Just a bit uneasy that published SL5 binaries always end up a few versions behind, but not biggie. Thanks!

@mythz
Copy link
Member

mythz commented Jun 17, 2013

Yeah only temporary till custom client builds are removed from the BSD packages.

After that I'll be looking at creating and maintaining commercial PCL builds if possible. The alternative option available will be maintaining custom binary builds and packages in their own forks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants