Skip to content
This repository was archived by the owner on Dec 24, 2022. It is now read-only.

Added XmlElement test and possible fixes to fix test #361

Merged
merged 7 commits into from
Aug 8, 2013
Merged

Added XmlElement test and possible fixes to fix test #361

merged 7 commits into from
Aug 8, 2013

Conversation

WimAtIHomer
Copy link
Contributor

Had a problem with a generated XmlAny property from a xsd.
I added the XmlElement to a test and made a few fixes to allow the test to succeed.

One of the changes is to support ICollection like IEnumerable, I also added a test for this.
I added one extra Assert to the IEnumerable test to detect the return error I made previously.

All Unit Test succeeded except 2 unrelated

  • test_rect_different_cultures("de") failed with System.NotSupportedException
  • test_rect_different_cultures("en") failed with System.NotSupportedException

Had a problem that a XmlAny type (XmlElement[]) could not be parsed
null check for GetTypeWithGenericsInterfaceOf(typeof(IEnumerable<>)
and make ICollection behave the same as IEnumerable
Also added extra Assert in IEnumerable test
mythz added a commit that referenced this pull request Aug 8, 2013
Added XmlElement test and possible fixes to fix test
@mythz mythz merged commit 325d295 into ServiceStack:master Aug 8, 2013
@mythz
Copy link
Member

mythz commented Aug 8, 2013

ok great, thx.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants