Skip to content
This repository was archived by the owner on Jan 18, 2023. It is now read-only.

Conversation

inje
Copy link
Contributor

@inje inje commented Jul 15, 2018

No description provided.

@inje inje requested a review from felix2feng July 15, 2018 00:45
@inje inje force-pushed the inje/contract-artifacts branch from 72cb14b to 7bea0bc Compare July 15, 2018 00:46
@@ -975,12 +1019,12 @@
"unitAlias": ""
},
{
"absolutePath": "/Users/justinkchen/workspace/set-protocol-contracts/contracts/core/extensions/CoreIssuanceOrder.sol",
"absolutePath": "/Users/inje/Documents/repos/set-protocol-contracts/contracts/core/extensions/CoreIssuanceOrder.sol",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if its weird that the absolute path is your own directory

Copy link
Contributor Author

@inje inje Jul 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered that too when Justin updated artifacts, but it had no side-effects. Before Justin's absolute path, it was Alex's, and our contract migrations ran just fine.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 624

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.741%

Totals Coverage Status
Change from base Build 579: 0.0%
Covered Lines: 286
Relevant Lines: 286

💛 - Coveralls

@inje inje merged commit 733fd66 into master Jul 15, 2018
@inje inje deleted the inje/contract-artifacts branch July 15, 2018 02:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants