This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Alex/kyber wrapper issuance specs #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1968
💛 - Coveralls |
felix2feng
reviewed
Sep 29, 2018
| @@ -120,12 +152,12 @@ contract KyberNetworkWrapper is | |||
| } | |||
|
|
|||
| // Transfer any unused or remainder maker token back to the issuance order user | |||
| uint remainderSourceToken = ERC20.balanceOf(_makerToken, this); | |||
| if (remainderSourceToken > 0) { | |||
| uint remainderMakerToken = ERC20.balanceOf(_makerToken, this); | |||
| function getExpectedRate( | ||
| address src, | ||
| address dest, | ||
| uint srcQty |
There was a problem hiding this comment.
Unless its an issue, specify uint256?.
There was a problem hiding this comment.
This is in the external folder. Leaving it to match their interface like we did in the other external files
| const sourceTokenDecimals = (await makerToken.decimals.callAsync()).toNumber(); | ||
| kyberConversionRatePower = new BigNumber(10).pow(18 + sourceTokenDecimals - componentTokenDecimals); | ||
| const minimumConversionRate = maxDestinationQuantity.div(sourceTokenQuantity) | ||
| .mul(kyberConversionRatePower) |
There was a problem hiding this comment.
I love the math steps put on their own line
| .mul(kyberConversionRatePower) | ||
| .round(); | ||
| kyberTradeMakerTokenChange = sourceTokenQuantity.sub( | ||
| maxDestinationQuantity.mul(kyberConversionRatePower).div(KYBER_RESERVE_CONFIGURED_RATE).floor()); |
There was a problem hiding this comment.
Possible to separate math steps into their own line here?
There was a problem hiding this comment.
Not a lot of clarity or meaning for the in between steps in this case
There was a problem hiding this comment.
Oh, I see what you mean, I thought it was confusing cause it's layered inside one sub already so I didn't do that here
asoong
force-pushed
the
alex/kyber_wrapper_issuance_specs
branch
from
1c74130 to
3053912
Compare
felix2feng
approved these changes
Sep 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required several updates to the snapshot including increasing the reserve balance, category cap, and imbalances.