This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Accounting and Issuance Optimizations #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
felix2feng
commented
Nov 21, 2018
felix2feng
commented
- Make usage of batch functions
- Moved deposit, increment, decrement and withdraw quantity calculations into separate functions
- Remove IssuanceComponentDeposited log
Pull Request Test Coverage Report for Build 2968
💛 - Coveralls |
bweick
reviewed
Nov 21, 2018
| _quantities[i] | ||
| ); | ||
| } | ||
| ITransferProxy(state.transferProxy).batchTransfer( |
There was a problem hiding this comment.
Would be good to add some comments here
bweick
reviewed
Nov 21, 2018
| state.vault | ||
| ); | ||
|
|
||
| IVault(state.vault).batchIncrementTokenOwner( |
bweick
reviewed
Nov 21, 2018
| @@ -137,43 +129,37 @@ contract CoreIssuance is | |||
| uint256 naturalUnit = setToken.naturalUnit(); | |||
| address[] memory components = setToken.getComponents(); | |||
| uint256[] memory units = setToken.getUnits(); | |||
| uint256[] memory componentQuantities = calculateTransferValues( | |||
There was a problem hiding this comment.
Comments needed in this function
bweick
reviewed
Nov 21, 2018
| @@ -240,65 +226,40 @@ contract CoreIssuance is | |||
| uint256 naturalUnit = setToken.naturalUnit(); | |||
| address[] memory components = setToken.getComponents(); | |||
| uint256[] memory units = setToken.getUnits(); | |||
| uint256[] memory requiredComponentQuantities = calculateTransferValues( | |||
bweick
reviewed
Nov 21, 2018
| ( | ||
| uint256[] memory decrementTokenOwnerValues, | ||
| uint256[] memory depositValues | ||
| ) = calculateDepositAndDecrementQuantities( |
bweick
reviewed
Nov 21, 2018
| vaultBalance | ||
| ); | ||
| } | ||
| vault.batchDecrementTokenOwner( |
bweick
reviewed
Nov 21, 2018
| amountToDeposit | ||
| ); | ||
| } | ||
| ITransferProxy(state.transferProxy).batchTransfer( |
bweick
approved these changes
Nov 21, 2018
felix2feng
force-pushed
the
felix/accounting-issuance-opt
branch
from
52d14d7 to
b4022c3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.