This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Fixed keccak, exponential type casting, and other small warnings. #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bweick
force-pushed
the
brian/fix_warnings
branch
from
4d32284 to
fc505c7
Compare
|
LGTM, can you also go ahead and remove the ABI Encoder lines? |
asoong
approved these changes
Jun 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main warnings of concern were an implicit type casting of exponentials and a deprecation warning for packing variables for hashing that felt it was a good idea to just fix now since it seems it will be changed in the next solidity update.