This repository was archived by the owner on Jan 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
Rebalancing Set Exchange Issuance: Log Change and other metadata #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6087
💛 - Coveralls |
bweick
reviewed
Aug 2, 2019
|
||
it('refunds the user the appropriate amount of eth', async () => { | ||
const previousEthBalance: BigNumber = new BigNumber(await web3.eth.getBalance(subjectCaller)); | ||
describe('', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add describe
bweick
reviewed
Aug 2, 2019
customIssuePaymentTokenAmount = new BigNumber(10 ** 10); | ||
const excessEth = new BigNumber(10 ** 10); | ||
|
||
describe('', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add describe
bweick
reviewed
Aug 2, 2019
customIssuePaymentTokenAmount = new BigNumber(10 ** 10); | ||
const excessTokenAmount = new BigNumber(10 ** 10); | ||
|
||
describe('', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add describe
bweick
reviewed
Aug 2, 2019
|
||
it('refunds the user the appropriate amount of weth', async () => { | ||
const previousWethBalance: BigNumber = await weth.balanceOf.callAsync(subjectCaller); | ||
describe('', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add describe
bweick
approved these changes
Aug 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.