This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Master TWAP Auction Branch #625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bweick
force-pushed
the
brian/twap_auction
branch
from
7cd3f2b to
b5374a8
Compare
Pull Request Test Coverage Report for Build 7968
💛 - Coveralls |
felix2feng
reviewed
Apr 30, 2020
| return auction(_set).remainingCurrentSets; | ||
| } | ||
|
|
||
| function startingCurrentSets(address _set) external view returns (uint256) { |
There was a problem hiding this comment.
It would have been cool to make these prefixed w/ get as well. But understand how it wouldn't be backwards compatible
felix2feng
reviewed
Apr 30, 2020
| it('returns the correct combined current set units', async () => { | ||
| const combinedCurrentSetUnits = await subject(); | ||
|
|
||
| expect(JSON.stringify(combinedCurrentSetUnits)).to.equal(JSON.stringify(auctionState.combinedCurrentSetUnits)); |
There was a problem hiding this comment.
Man, we need a test-helper to do array comparisons that stringifies it for us
* TWAPAuction constructor and tests. * LiquidatorUtils finished and beginning of intialization. * Implementation done. Some clean up to do still but end points implemented. Tests still to finish up. * Added testing for validateLiquidatorData. * Add remaining sets from chunk auction back to orderRemaining for next chunkAuction calculations. * remove .only * Added testing. * Add some additonal testing, and tighten up some auctionNextChunk logic. * Renaming variable. * Update logic to prevent potential overflow. * Added some comments and clarifying javadocs. Additonal testing. * Added comments to clarify when amount of sets is being used vs currency value. * Some additional comments and reformatting. * Renamed usdChunkSize. * Implement and test TWAP Liquidator (#627) * Getters for TWAP auction. * Create twap auction base * Add helpers * Merge * Initial tests * write chunk bound test * Add some specs * Complete logic * Write test * Finish startrebalance tests * Finish finish bid test * Complete place bid * testing iterate * Fix helpers * Remove package.json .only * Fix linting * Complete validation * Make some tweaks based on comments * Make tweak Co-authored-by: bweick <brian.weickmann@gmail.com> Co-authored-by: Felix Feng <felix2feng@gmail.com>
…col-contracts into brian/twap_auction
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.