This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Alex/decode order data #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoong
commented
Jul 2, 2018
| ); | ||
| require( | ||
| to < b.length, | ||
| to <= b.length, |
There was a problem hiding this comment.
@felix2feng did they respond to your question about this?
asoong
commented
Jul 2, 2018
| const exchange = _.sample(EXCHANGES); | ||
| exchangeOrderDatum.push(paddedBufferForData(exchange)); | ||
|
|
||
| const orderLength = _.random(120, 160) |
There was a problem hiding this comment.
Hoping to sub any kind of util function we write later that generates a real exchange order that mirrors what setProtocol.js will return
There was a problem hiding this comment.
I've been already starting to generate more realistic orders. We can fix after my PR goes through
bweick
approved these changes
Jul 3, 2018
felix2feng
reviewed
Jul 3, 2018
| ); | ||
| require( | ||
| to < b.length, | ||
| to <= b.length, |
| const exchange = _.sample(EXCHANGES); | ||
| exchangeOrderDatum.push(paddedBufferForData(exchange)); | ||
|
|
||
| const orderLength = _.random(120, 160) |
There was a problem hiding this comment.
I've been already starting to generate more realistic orders. We can fix after my PR goes through
| import { CoreState } from "../lib/CoreState.sol"; | ||
|
|
||
|
|
||
| // /** |
There was a problem hiding this comment.
Why are there 2 types of comments here?
contracts/core/lib/CoreState.sol
Outdated
| /* ============ Structs ============ */ | ||
|
|
||
| struct State { | ||
| // Mapping of exchagne enumeration to address |
| // ============ Structs ============ | ||
|
|
||
| struct OrderHeader { | ||
| uint8 exchange; |
There was a problem hiding this comment.
FYI - Currently, we don't get any storage savings from packing with just a uint8
asoong
force-pushed
the
alex/decode_order_data
branch
from
ea6c75a to
87567a7
Compare
* Adding lib bytes and removing coverage of it. * Add slice * Add content address
Pull Request Test Coverage Report for Build 384
💛 - Coveralls |
asoong
force-pushed
the
alex/decode_order_data
branch
2 times, most recently
from
e35fc9b to
f240377
Compare
asoong
force-pushed
the
alex/decode_order_data
branch
from
f240377 to
5e0f168
Compare
bweick
approved these changes
Jul 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MockExchangeOrderHandlerwhich was added just to test theExchangeOrderHandlerlibraryExchangeDispatcheras an Core extension to manage valid exchanges that can be used to fill the issuanceOrder