This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Brian/factory and token arrays #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix2feng
approved these changes
Jul 3, 2018
| await subject(); | ||
|
|
||
| const setTokens = await core.setTokens.callAsync(); | ||
| expect(setTokens).to.not.include(setToken.address); |
There was a problem hiding this comment.
You can also add an assertion to expected array length
| isValidFactory(_factoryAddress) | ||
| { | ||
| state.validFactories[_factoryAddress] = false; | ||
| for (uint256 i = 0; i < state.factories.length; i++) { |
There was a problem hiding this comment.
Can we create an address[] helper method for this?
There was a problem hiding this comment.
I'll add to Trello and we can decide. Wanna get this merged within the scope of what it is.
Pull Request Test Coverage Report for Build 500
💛 - Coveralls |
bweick
force-pushed
the
brian/factory_and_token_arrays
branch
3 times, most recently
from
5a69278 to
7877941
Compare
bweick
force-pushed
the
brian/factory_and_token_arrays
branch
from
30f9ae7 to
48eb564
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.