Skip to content
This repository was archived by the owner on Jan 18, 2023. It is now read-only.

Exchange Wrapper Set Up #89

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Exchange Wrapper Set Up #89

merged 1 commit into from
Jul 5, 2018

Conversation

felix2feng
Copy link
Contributor

  • Add Exchange Wrapper contracts
  • Add parsing of makerAsset
  • Lots of test helpers with creating order data

asoong
asoong approved these changes Jul 5, 2018
View reviewed changes
test/core/external/zeroExExchangeWrapper.spec.ts
);
});

describe("#exchange", async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@asoong
Copy link
Contributor

asoong commented Jul 5, 2018

Squash

@felix2feng
Add 0x interfaces
fcc21c8 
Import interfacesD

Blah

Need to get to the bottom of this

Finish parsing maker data

Remove all external from solcoverage
@felix2feng felix2feng merged commit 4772497 into master Jul 5, 2018
@felix2feng felix2feng deleted the felix/0x-wrapper branch July 5, 2018 21:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@asoong asoong asoong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felix2feng @asoong