This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Brian/order settlement #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoong
reviewed
Jul 6, 2018
|
|
||
| // Check that maker's component tokens in Vault have been incremented correctly | ||
| for (uint16 i = 0; i < components.length; i++) { | ||
| uint currentBal = IVault(state.vaultAddress).getOwnerBalance( |
There was a problem hiding this comment.
Thinking through the possibilities and vulns here - issue transfers from the user account if the required component amount is not in the vault.
asoong
reviewed
Jul 6, 2018
| uint[] memory componentUnits = ISetToken(_order.setAddress).getUnits(); | ||
|
|
||
| // Calculate amount of component tokens required to issue | ||
| for (uint16 i = 0; i < components.length; i++) { |
There was a problem hiding this comment.
I wonder if this is necessary. Issue will fail automatically if the correct component amounts are not either in the vault or the users account
bweick
force-pushed
the
brian/order_settlement
branch
6 times, most recently
from
cbe4121 to
f62688d
Compare
Pull Request Test Coverage Report for Build 544
💛 - Coveralls |
asoong
approved these changes
Jul 11, 2018
| }); | ||
|
|
||
| // Verify signature is authentic | ||
| //Verify signature is authentic |
| uint[] memory requiredBalances = new uint[](_order.requiredComponents.length); | ||
|
|
||
| // Calculate amount of maker token required | ||
| // Look into rounding errors |
| _order.makerAddress, | ||
| _order.requiredComponents[i] | ||
| ); | ||
| //require(currentBal >= requiredBalances[i]); |
There was a problem hiding this comment.
This is pending taker wallet exchange I assume?
| _values[2], // expiration | ||
| _values[3], // relayerTokenAmount | ||
| _values[4] // salt | ||
| _addresses[0], // setAddress |
There was a problem hiding this comment.
Can we add descriptions to each of these?
… tooling for signing IssuanceOrders that contain arrays off-chain.
bweick
force-pushed
the
brian/order_settlement
branch
from
33327df to
ffd823e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.