Skip to content
This repository was archived by the owner on Jan 18, 2023. It is now read-only.

Conversation

asoong
Copy link
Contributor

@asoong asoong commented Jul 7, 2018

No description provided.

@asoong asoong requested a review from a team July 7, 2018 07:13
@coveralls
Copy link

coveralls commented Jul 7, 2018

Pull Request Test Coverage Report for Build 475

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 99.685%

Totals Coverage Status
Change from base Build 467: 0.3%
Covered Lines: 229
Relevant Lines: 229

💛 - Coveralls

@asoong asoong force-pushed the alex/common_math branch from 5ab1fc8 to ac8543e Compare July 7, 2018 08:18
Copy link
Contributor

@felix2feng felix2feng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thanks for doing it.

@@ -1,13 +1,13 @@
pragma solidity 0.4.24;
pragma experimental "ABIEncoderV2";

import { ZeroExOrderDataHandler } from "../../core/exchange-wrappers/lib/ZeroExOrderDataHandler.sol";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolute path could be helpful here.


let commonMathLibrary: CommonMathMockContract;

describe("#testMaxUInt256", async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this

@asoong asoong merged commit 16ea269 into master Jul 7, 2018
@asoong asoong deleted the alex/common_math branch July 7, 2018 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants