Skip to content
This repository was archived by the owner on Jan 18, 2023. It is now read-only.

Conversation

justinkchen
Copy link
Contributor

…while removing old deleted ones like AddressArrayUtils

@justinkchen justinkchen force-pushed the justin_chen-update-artifacts branch from 2bc51a1 to 485341e Compare July 7, 2018 17:25
Copy link
Contributor

@inje inje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
There are some comments about absolute local paths, but I'm guessing that's expected since Alex had those as well from before.

@@ -2,6 +2,11 @@ import * as _ from "lodash";
import * as Web3 from "web3";
import { TxData, TxDataPayable } from "./common";

export const CONTRACT_WRAPPER_ERRORS = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using this?

"source": "pragma solidity 0.4.23;\n\n\ncontract Migrations {\n address public owner;\n uint public lastCompletedMigration;\n\n modifier restricted() {\n if (msg.sender == owner) _;\n }\n\n constructor() public {\n owner = msg.sender;\n }\n\n function setCompleted(uint completed) public restricted {\n lastCompletedMigration = completed;\n }\n\n function upgrade(address newAddress) public restricted {\n Migrations upgraded = Migrations(newAddress);\n upgraded.setCompleted(lastCompletedMigration);\n }\n}\n",
"sourcePath": "/Users/alexsoong/Source/set-protocol/set-protocol-contracts/contracts/Migrations.sol",
"source": "pragma solidity 0.4.24;\n\n\ncontract Migrations {\n address public owner;\n uint public lastCompletedMigration;\n\n modifier restricted() {\n if (msg.sender == owner) _;\n }\n\n constructor() public {\n owner = msg.sender;\n }\n\n function setCompleted(uint completed) public restricted {\n lastCompletedMigration = completed;\n }\n\n function upgrade(address newAddress) public restricted {\n Migrations upgraded = Migrations(newAddress);\n upgraded.setCompleted(lastCompletedMigration);\n }\n}\n",
"sourcePath": "/Users/justinkchen/workspace/set-protocol-contracts/contracts/Migrations.sol",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this is autogenerated since Alex's name was in the last "sourcePath". I'm guessing this is normal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea would be good to get it out so that its not changed everytime, but it is part of the compilation

"sourceMap": "",
"deployedSourceMap": "",
"source": "/*\n Copyright 2018 Set Labs Inc.\n\n Licensed under the Apache License, Version 2.0 (the \"License\");\n you may not use this file except in compliance with the License.\n You may obtain a copy of the License at\n\n http://www.apache.org/licenses/LICENSE-2.0\n\n Unless required by applicable law or agreed to in writing, software\n distributed under the License is distributed on an \"AS IS\" BASIS,\n WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n See the License for the specific language governing permissions and\n limitations under the License.\n*/\n\npragma solidity 0.4.24;\n\n\n/**\n * @title IExchange\n * @author Set Protocol\n *\n * Interface for executing an order with an exchange\n */\ninterface IExchange {\n\n /**\n * Exchange some amount of takerToken for makerToken.\n *\n * @param _orderData Arbitrary bytes data for any information to pass to the exchange\n * @return uint256 The amount of makerToken received\n */\n function exchange(\n bytes _orderData\n )\n external\n returns (uint256);\n}\n",
"sourcePath": "/Users/justinkchen/workspace/set-protocol-contracts/contracts/core/interfaces/IExchange.sol",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing an absolute local path. Will this work?

@coveralls
Copy link

coveralls commented Jul 7, 2018

Pull Request Test Coverage Report for Build 480

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.685%

Totals Coverage Status
Change from base Build 478: 0.0%
Covered Lines: 229
Relevant Lines: 229

💛 - Coveralls

@justinkchen justinkchen force-pushed the justin_chen-update-artifacts branch from e4edf3b to f862518 Compare July 7, 2018 18:28
@justinkchen justinkchen merged commit f131f66 into master Jul 7, 2018
@justinkchen justinkchen deleted the justin_chen-update-artifacts branch July 7, 2018 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants