This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Add two MA crossover trigger #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bweick
reviewed
Jul 1, 2020
| ) | ||
| public | ||
| { | ||
| longTermMAOracle = _longTermMAOracle; |
There was a problem hiding this comment.
Wouldn't these both be the same oracle, just different days passed in?
There was a problem hiding this comment.
I guess that's true if we are using the same time frame i.e. 12 day EMA and 26 day EMA
There was a problem hiding this comment.
Keeping it flexible in case someone wants to do an hourly MA crossing a daily MA, or a 20 SMA crossing a 26 EMA etc
felix2feng
approved these changes
Jul 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.