This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Brian/manager audit fixes #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alancing set state. Change proposalTimestamp to lastProposalTimestamp. Comments and small logic updates.
…ror messages in flexible manager library. Added tests for non-default states to make sure they revert.
… to create new collateral sets.
…be called once when rebalancingSetTokenAddress is guaranteed to be zero.
felix2feng
approved these changes
Jun 12, 2019
package.json
Outdated
| "transpile": "tsc", | ||
| "truffle-test-scenarios": "truffle test `find transpiled/test/scenarios -name '*.spec.js'`", | ||
| "truffle-test-contracts": "truffle test `find transpiled/test/contracts -name '*.spec.js'`", | ||
| "truffle-test-contracts": "truffle test `find transpiled/test/contracts -name 'ethTwentyDayMACOManager.spec.js'`", |
|
|
||
| address public usdcAddress; | ||
| address public ethAddress; | ||
| address public wethAddress; |
There was a problem hiding this comment.
Given our asset roll-out strategy, we may want to consider generalizing the weth and usdc addresses
There was a problem hiding this comment.
It's something I've considered. We could do wethAddress -> riskAssetAddress, usdcAddress -> stableAssetAddress, then get the decimals from both of those in the constructor and that should be all we need. Perhaps a require to make sure the stableCollateral component matches stableAssetAddress and likewise for the risk asset?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.