This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Update Constant Update gas-price TimeSeriesFeed #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bweick
reviewed
Aug 27, 2019
| uint256[] memory currentTimeSeriesValues = _self.readListMemory(1); | ||
| return currentTimeSeriesValues[0]; | ||
| } | ||
|
|
bweick
reviewed
Aug 27, 2019
| pragma solidity 0.5.7; | ||
| pragma experimental "ABIEncoderV2"; | ||
| import { LinkedListLibraryV2 } from "./LinkedListLibraryV2.sol"; | ||
|
|
bweick
reviewed
Aug 27, 2019
|
|
||
| import { OracleWrapper } from '@utils/wrappers/oracleWrapper'; | ||
|
|
||
| import { TimeSeriesFeedState } from '../../../types/timeSeriesFeed'; |
There was a problem hiding this comment.
Think we'll want to move this into set-protocol-utils because it's used in setProtocol.js
There was a problem hiding this comment.
But fine with it here as a temporary measure.
bweick
reviewed
Aug 27, 2019
| }); | ||
|
|
||
| describe('#read', async () => { | ||
| describe.only('#read', async () => { |
bweick
reviewed
Aug 27, 2019
types/timeSeriesFeed.ts
Outdated
| @@ -0,0 +1,13 @@ | |||
| import { BigNumber } from "bignumber.js"; | |||
|
|
|||
| export interface LinkedList { | |||
There was a problem hiding this comment.
Suppose we'd also have to add this to set-protocol-utils
bweick
reviewed
Aug 27, 2019
|
|
||
| return outputArray; | ||
| } | ||
|
|
bweick
approved these changes
Aug 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.