Aave V2 Library and Fixture

[0xSachinK]

Aave V2 Library contract:

• Hosts a collection of invoking functions that enable SetToken modules to invoke SetToken interactions with AaveV2
• Has getter functions that generate calldata to interact with AaveV2
  • Can be used by off-chain workers/managers to generate the required calldata

Aave V2 Fixture:

• Creates the entire AaveV2 environment locally and initializes it with a known state to run our tests
• Has helper functions to perform common tasks such as creating & activating a reserve on AaveV2

• Uses

  • Write tests for AaveV2 Library contract
  • Write tests for Aave Leverage Module contract
  • Write tests for any contracts we write in the future which needs an AaveV2 mock environment

Implementation

• Write Aave V2 Fixture
• Write tests for Aave V2 Fixture
• Write Aave V2 Library contract
• Write tests for Aave V2 Library contract
  • Write Aave V2 Mock contract
  • Use fixture and mock contract to write tests for Aave V2 Library contract

Further Reading

STIP: Aave Leverage Module

Note: @ncitron needs to port over the existing Aave V2 governance-related functionality from the Aave fixture to the new Aave V2 fixture.

[ncitron]

Looks pretty solid to me. Made some usability comments in the fixture. Also make sure to add parameter lists and return values to your javadoc comments

[richardliang]

Overall pretty close. Assuming we're changing all the public get calldata functions to internal functions to save gas as we discussed in DMs

[0xSachinK]

Assuming we're changing all the public get calldata functions to internal functions to save gas as we discussed in DMs

Calldata generation method	Gas Used
External invoke function generating calldata by itself	23563
External invoke function calling internal getter function to generate calldata	23583
External invoke function calling public getter function to generate calldata	23627

All cost approximately the same amount of gas. Hence, we can stick to the current version, as it is comparatively cheaper to deploy than the others.