ALM integration tests #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove extra 'greater than equal to' comparisons. * WBTC only has 8 decimal places which is less compared to 18 decimal places in WETH. Lesser the number of decimal places, lesser is the chance of the aToken returning a balance with 1 wei error. * Also interest accrues with less granularity which saves us the pain of having to calculate interest rates and take those extra few wei into account.
bweick
reviewed
Sep 1, 2021
There was a problem hiding this comment.
Can you expand on the reasoning why aBTC doesn't face some of the same rounding issues as aETH? Where were you getting reverts for aETH? Is it possible we just need to issue more Sets?
Other than that a couple comments. I think we need to beef up the testing on the double borrow/repay stuff.
…emption * when default and external positions do not overlap
* Add an explanation for why we used WBTC and USDC * Explain why use greater than equal to, whenever it is used
bweick
reviewed
Sep 3, 2021
* Being more explicit with the checks
bweick
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
greater than or equal tocomparisons.gtecomparisons. Replace it withgreater than or equal to with an upper boundcomparison. And give a clear reason to use it.