Adding CompClaimAdapter #88
Conversation
gmbronco
force-pushed
the
comp-claim-adapter
branch
from
b1001ae to
06bf2da
Compare
|
|
||
| // Address of COMP token | ||
| // https://compound.finance/docs#networks | ||
| // address public immutable compToken; |
There was a problem hiding this comment.
Feel free to delete if it's not needed
|
|
||
| /** | ||
| * @title CompClaimAdapter | ||
| * @author Set Protocol |
| const amount: number = 1; | ||
|
|
||
| before(async () => { | ||
| await comptroller.mock.compAccrued.returns(amount); |
There was a problem hiding this comment.
Wow nice, I didn't realize waffle had the ability to mock contracts and mock values
| const receipt = await claim.wait(); | ||
|
|
||
| // Get RewardClaimed event dispatched in a ClaimModule#_claim call | ||
| const rewardClaimed: any = receipt.events.find((e: any): any => e.event == "RewardClaimed"); |
There was a problem hiding this comment.
So the actual claimComp doesn't transfer any tokens? Ideally it would be a mock to transfer reward token to the SetToken and check the balance of:
https://github.com/SetProtocol/set-protocol-v2/blob/master/test/protocol/modules/claimModule.spec.ts#L970
There was a problem hiding this comment.
Good point, I used ComptrollerMock that was already in the repo. It's claiming function is triggering a transfer on a mocked Comp ERC20 token. New test is added below and it's checking how the balance changes after the #claim is executed.
gmbronco
force-pushed
the
comp-claim-adapter
branch
from
06bf2da to
81b4f6b
Compare
This is a simple claim adapter that allows managers to claim COMP from assets deposited on Compound.
It's interfacing with Comptroller and conforms to the IClaimAdapter interface used by the Set Protocol V2 ClaimModule.
Tests are using mocked Comptroller contract and are limited to ClaimAdapter <> ClaimModule integration.