Skip to content

Conversation

kimpers
Copy link
Contributor

@kimpers kimpers commented May 27, 2021

Code Review Processes

We are looking to deploy a new VIP source for Uniswap V3 (pending ZEIP-88 vote). This updates the ZeroExApiAdapter to support this new source.

Code Checks

  • Add explanatory comments. If there is complex code that requires specific context or understanding, note that in a comment
  • Remove unncessary comments. Any comments that do not add additional context, information, etc. should be removed
  • Add javadocs.
  • Scrub through the code for inconsistencies (e.g. removing extra spaces)
  • Ensure there are not any .onlys in spec files

Broader Considerations

  • Ensure variable, function and event naming is clear, consistent, and reflective for the scope of the code.
  • Consider if certain pieces of logic should be placed in a different library, module

Copy link
Contributor

@asoong asoong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asoong asoong merged commit 7f8048d into SetProtocol:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants