Skip to content

Perp Manager post testing fixes #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 20, 2022
Merged

Perp Manager post testing fixes #9

merged 4 commits into from
Jan 20, 2022

Conversation

0xSachinK
Copy link
Contributor

@0xSachinK 0xSachinK commented Jan 20, 2022 •
edited
Loading

  • Updated RebalanceIterated event signature
    • Should emit newTwapLeverageRatio
  • Updated require checks, replace baseBalance checks with CLR checks
    • Require CLR to be zero while calling engage
    • Require CLR to NOT be zero while calling rebalance, iterateRebalance, ripcord and disengage
  • Update javadocs to explain why we need to use a separate function for calculating totalRebalanceNotional during engage
    • We need to cause the standard formula doesn't work when CLR is zero in engage

@bweick bweick merged commit b73e6bb into master Jan 20, 2022
@bweick bweick deleted the sachin/perp-manager-fixes branch January 20, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgewecke cgewecke Awaiting requested review from cgewecke

@richardliang richardliang Awaiting requested review from richardliang

1 more reviewer

@bweick bweick bweick approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xSachinK @bweick