Create new PerpV2LeverageViewerAPI for PerpModule Viewer contract #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkchen
reviewed
Jan 20, 2022
| * @param setTokenAddress Instance of the SetToken | ||
| * @param callerAddress Address of the method caller | ||
| * | ||
| * @return Array of info concerning size and leverage of current vAsset positions |
There was a problem hiding this comment.
can we add more info here in comments when we have this more concrete?
There was a problem hiding this comment.
well i guess nvm you do have VAssetDisplayInfo in the return so i guess can figure out from looking there
justinkchen
reviewed
Jan 20, 2022
src/types/common.ts
Outdated
| export type VAssetDisplayInfo = { | ||
| symbol: string; | ||
| address: Address; | ||
| positionUnit: BigNumber; |
There was a problem hiding this comment.
maybe add some comments here about how these numbers are in units of 10^18
justinkchen
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PerpV2LeverageViewerAPI for the upcoming contract that will abstract a lot of data getters out of the existing PerpV2LeverageModule.
Relevant smart contract PR: SetProtocol/set-protocol-v2#185