Skip to content

Conversation

cgewecke
Copy link
Contributor

PR:

  • adds a missing statement to the circle logic that splits tests between parallel containers. (Both containers were running all the tests)
  • upgrades ganache to V7 (~3X faster than V6)
  • uses Node 12 container in CI (necessary for V7)

Cuts ~ 12 min (75%) from test job.

One consideration is whether upgrading the Node version here is ok. I think this is fine for set-ui since:

  • we already install with --ignore-engines over there (by default it's pinned to 10.13)
  • it's only for a dev dependency

Benchmarks

Branch Test Time
master 17m 6s
PR 4m 53s

@cgewecke cgewecke requested a review from justinkchen February 17, 2022 19:43
@cgewecke cgewecke merged commit 925438f into master Feb 17, 2022
@cgewecke cgewecke deleted the chris/speed-up-ci branch February 17, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants