Skip to content

Add caller to the batch fetch methods so that gas can be estimated #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Add caller to the batch fetch methods so that gas can be estimated #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aba8fa
Add callerAddress as an optional param in batch fetch methods
justinkchen Apr 8, 2021
2009741
Bump version
justinkchen Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "set.js",
"version": "0.1.1",
"version": "0.1.2",
"description": "A javascript library for interacting with the Set Protocol v2",
"keywords": [
"set.js",
Expand Down
14 changes: 10 additions & 4 deletions src/api/SetTokenAPI.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,14 +202,18 @@ export default class SetTokenAPI {
* @param userAddress Address of the user
* @returns The balances of the ERC20 tokens for the user in array of BigNumbers format
*/
public async batchFetchBalancesOfAsync(tokenAddresses: Address[], userAddress: Address): Promise<BigNumber[]> {
public async batchFetchBalancesOfAsync(
tokenAddresses: Address[],
userAddress: Address,
callerAddress: Address = undefined
): Promise<BigNumber[]> {
this.assert.schema.isValidAddress('userAddress', userAddress);
const ownerAddresses = tokenAddresses.map(tokenAddress => {
this.assert.schema.isValidAddress('tokenAddress', tokenAddress);
return userAddress;
});

return await this.protocolViewerWrapper.batchFetchBalancesOf(tokenAddresses, ownerAddresses);
return await this.protocolViewerWrapper.batchFetchBalancesOf(tokenAddresses, ownerAddresses, callerAddress);
}

/**
Expand All @@ -222,7 +226,8 @@ export default class SetTokenAPI {
public async batchFetchAllowancesAsync(
tokenAddresses: Address[],
ownerAddress: Address,
spenderAddress: Address
spenderAddress: Address,
callerAddress: Address = undefined
): Promise<BigNumber[]> {
this.assert.schema.isValidAddress('ownerAddress', ownerAddress);
this.assert.schema.isValidAddress('spenderAddress', spenderAddress);
Expand All @@ -238,7 +243,8 @@ export default class SetTokenAPI {
return await this.protocolViewerWrapper.batchFetchAllowances(
tokenAddresses,
ownerAddresses,
spenderAddresses
spenderAddresses,
callerAddress
);
}

Expand Down