Fix circleci badge (attempt 2) #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like CircleCI badges generated via [these steps](https://circleci.com/docs/2.0/status-badges/#creating-badges-for-private-repositories96166267374796c653d736869656c64) don't render correctly in this README. My suspicion is that the `.` in set.js is a possible cause. I generated a shield badge via https://shields.io/category/build and it works in the preview
Merged
cgewecke
approved these changes
Aug 31, 2021
|
Potentially no longer necessary because attempt 1 appears to work now (?!)
Is it plausible that CircleCI was not providing this image until shields.io fetched it? I'm confused. |
|
Hahahah!!! I have no idea. I'm going to re-open this and merge because this seems more stable and all the other links use the same service. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like CircleCI badges generated via these steps don't render correctly in this README. My suspicion is that the
.in set.js is a possible cause.I generated a shield badge via https://shields.io/category/build and it works in the preview